Dave/CFTunnels
1
0
Fork 0
forked from Hithomelabs/CFTunnels
Code Pull Requests 3 Activity

Set Prune=true in redeployGitStack to fix container name conflict on redeploy #6

Open
Dave wants to merge 1 commits from fix/prune-containers into test
pull from: fix/prune-containers
merge into: Dave:test
Conversation 0 Commits 1 Files Changed 1 +1 -1
Dave commented 2026-07-08 21:43:48 +00:00
Owner
Copy Link

Summary

When portainer-automation redeploys the CFTunnels stack on Portainer, Docker returns a container name conflict because the existing container isn't removed first. This fix sets Prune: true in the redeploy request body so Portainer removes the old containers before creating new ones.

Changes

  • File: common/src/main/java/com/hithomelabs/common/portainer/client/PortainerApiClient.java
  • Change: In redeployGitStack, the second parameter to PortainerRedeployRequest constructor changed from false to true, setting the Prune field to true in the JSON body sent to Portainer's API.

Testing

  • Tests pass
  • Manual verification completed
## Summary When portainer-automation redeploys the CFTunnels stack on Portainer, Docker returns a container name conflict because the existing container isn't removed first. This fix sets `Prune: true` in the redeploy request body so Portainer removes the old containers before creating new ones. ## Changes - **File:** `common/src/main/java/com/hithomelabs/common/portainer/client/PortainerApiClient.java` - **Change:** In `redeployGitStack`, the second parameter to `PortainerRedeployRequest` constructor changed from `false` to `true`, setting the `Prune` field to `true` in the JSON body sent to Portainer's API. ## Testing - [ ] Tests pass - [ ] Manual verification completed
Dave added 1 commit 2026-07-08 21:43:49 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/prune-containers:fix/prune-containers
git checkout fix/prune-containers
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dave/CFTunnels#6
No description provided.
Delete Branch "fix/prune-containers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?