test #123

hitanshu · 2026-07-05T07:07:56Z

hitanshu commented

2026-07-05 07:07:56 +00:00

Works perfectly in test !

hitanshu added 3 commits 2026-07-05 07:07:56 +00:00

Hithomelabs/CFTunnels#69 : promote custom slim runner image (ci-runner:1.0.0) in test_image_build_push.yml 02736e43f7

Hithomelabs/CFTunnels#69 : promote custom slim runner image (ci-runner:1.0.0) in prod_image_tag_promote.yaml fa714ef498

Hithomelabs/CFTunnels#122 : replace actions/setup-java@v4 with Alpine-native JDK install for ci-runner container

sample gradle build and test / tag (push) Successful in 6s

Details

sample gradle build and test / build_tag_push (push) Successful in 3m29s

Details

Promote image with tag test to prod / tag (push) Successful in 9s

Details

Promote image with tag test to prod / build_tag_push (push) Successful in 16s

Details

Daily cloudflare API integration test / cloudflare-api-test (push) Successful in 1m48s

Details

32083f6ceb

hitanshu requested review from Linus 2026-07-05 07:12:39 +00:00

Linus approved these changes 2026-07-05 07:14:23 +00:00

Linus left a comment

PR Review: test → main — Custom CI Runner Image Promotion (ci-runner:1.0.0)

Overview

This PR promotes the custom slim CI runner image (ci-runner:1.0.0) from test to main. Changes were previously reviewed and merged into test (PR #122) and have been validated.

Files Changed (2 files, +6/-7)

File	Change
`test_image_build_push.yml`	Container image → `ci-runner:1.0.0` + Alpine JDK via `apk add openjdk17-jdk`
`prod_image_tag_promote.yaml`	Container image → `ci-runner:1.0.0` (no JDK needed — no Gradle build)

Code Quality

✅ Container image points to internal registry (192.168.0.100:8928/hithomelabs/ci-runner:1.0.0)
✅ Alpine JDK approach (apk add --no-cache openjdk17-jdk) is appropriate for a slim Alpine-based runner
✅ JAVA_HOME explicitly set via $GITHUB_ENV — good practice for Alpine's OpenJDK layout
✅ actions/checkout@v4 and gradle/actions/wrapper-validation@v3 remain unchanged

Security

✅ No secrets exposed
✅ Docker registry credentials use ${{ secrets.TOKEN }} — not hardcoded
✅ Internal registry address (192.168.0.100:8928) is appropriate for a private CI environment

Testing

✅ Already validated on test branch — "Works perfectly in test!"
✅ Identical changes were approved and merged to test via PR #122
✅ This is a clean promotion with no additional changes

Recommendations (non-blocking)

Consider version-pinning the Alpine JDK package — openjdk17-jdk without a version will track the latest 17.x from Alpine repos. If reproducibility matters, specify a full version like openjdk17-jdk=17.0.14_p7-r0 (or similar).
Registry URL as variable — Consider moving 192.168.0.100:8928 to a Gitea Actions variable (e.g., ${{ vars.REGISTRY_URL }}) for easier maintenance across workflows.

Approval Status

REVIEW COMPLETE — APPROVED ✅

This is a clean, validated promotion PR. The custom ci-runner:1.0.0 image has been tested on the test branch and is ready for main.

## PR Review: test → main — Custom CI Runner Image Promotion (ci-runner:1.0.0) ### Overview This PR promotes the custom slim CI runner image (`ci-runner:1.0.0`) from `test` to `main`. Changes were previously reviewed and merged into `test` (PR #122) and have been validated. ### Files Changed (2 files, +6/-7) | File | Change | |------|--------| | `test_image_build_push.yml` | Container image → `ci-runner:1.0.0` + Alpine JDK via `apk add openjdk17-jdk` | | `prod_image_tag_promote.yaml` | Container image → `ci-runner:1.0.0` (no JDK needed — no Gradle build) | ### Code Quality - ✅ Container image points to internal registry (`192.168.0.100:8928/hithomelabs/ci-runner:1.0.0`) - ✅ Alpine JDK approach (`apk add --no-cache openjdk17-jdk`) is appropriate for a slim Alpine-based runner - ✅ `JAVA_HOME` explicitly set via `$GITHUB_ENV` — good practice for Alpine's OpenJDK layout - ✅ `actions/checkout@v4` and `gradle/actions/wrapper-validation@v3` remain unchanged ### Security - ✅ No secrets exposed - ✅ Docker registry credentials use `${{ secrets.TOKEN }}` — not hardcoded - ✅ Internal registry address (`192.168.0.100:8928`) is appropriate for a private CI environment ### Testing - ✅ Already validated on `test` branch — "Works perfectly in test!" - ✅ Identical changes were approved and merged to `test` via PR #122 - ✅ This is a clean promotion with no additional changes ### Recommendations (non-blocking) 1. **Consider version-pinning the Alpine JDK package** — `openjdk17-jdk` without a version will track the latest 17.x from Alpine repos. If reproducibility matters, specify a full version like `openjdk17-jdk=17.0.14_p7-r0` (or similar). 2. **Registry URL as variable** — Consider moving `192.168.0.100:8928` to a Gitea Actions variable (e.g., `${{ vars.REGISTRY_URL }}`) for easier maintenance across workflows. ### Approval Status **REVIEW COMPLETE — APPROVED** ✅ This is a clean, validated promotion PR. The custom `ci-runner:1.0.0` image has been tested on the `test` branch and is ready for `main`.

Linus approved these changes 2026-07-05 07:14:26 +00:00

hitanshu merged commit 32083f6ceb into main

2026-07-05 07:15:06 +00:00

Sign in to join this conversation.

No reviewers